Skip to content

Elastic Search Implementation for Advanced Search#327

Merged
vanitha1822 merged 5 commits intorelease-3.6.1from
nd/vs/AMM-1951-ES
Jan 8, 2026
Merged

Elastic Search Implementation for Advanced Search#327
vanitha1822 merged 5 commits intorelease-3.6.1from
nd/vs/AMM-1951-ES

Conversation

@vanitha1822
Copy link
Member

@vanitha1822 vanitha1822 commented Dec 24, 2025

📋 Description

JIRA ID:

AMM-1951

✅ Type of Change

  • ✨ New feature (non-breaking change which adds functionality)

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 24, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vanitha1822 vanitha1822 requested a review from drtechie December 24, 2025 14:52
@vanitha1822 vanitha1822 self-assigned this Dec 24, 2025
drtechie
drtechie reviewed Dec 29, 2025
View reviewed changes
src/main/java/com/iemr/common/controller/beneficiary/BeneficiaryRegistrationController.java Outdated

// Get userId from JWT token

String jwtToken = httpRequest.getHeader("Jwttoken");
Copy link
Member

@drtechie drtechie Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent looks off.
Why do we keep reusing this logic in every controller?
Shouldn't this be an abstraction/ middleware that can inject current user id?

Copy link
Member Author

@vanitha1822 vanitha1822 Jan 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated. Added the logic in jwtUtil

drtechie
drtechie reviewed Dec 29, 2025
View reviewed changes
src/main/resources/application.properties Outdated
iemr.session.expiry.time.changePassword=600

identity-api-url-advancesearch =IDENTITY_BASE_URL/id/advanceSearch
identity-api-url-advancesearch-es =IDENTITY_BASE_URL/beneficiary/advanceSearchES
Copy link
Member

@drtechie drtechie Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

advanced, not advance

Copy link
Member Author

@vanitha1822 vanitha1822 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
9.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@vanitha1822 vanitha1822 merged commit 65efdc7 into release-3.6.1 Jan 8, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drtechie drtechie drtechie left review comments

@vishwab1 vishwab1 vishwab1 approved these changes

Assignees

@vanitha1822 vanitha1822

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vanitha1822 @drtechie @vishwab1